Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds in the question marks for consistency #36

Merged

Conversation

afbreilyn
Copy link
Contributor

fixes #35

@alexdovzhanyn alexdovzhanyn merged commit bd93b76 into master Feb 23, 2018
@alexdovzhanyn alexdovzhanyn deleted the creates-consisent-function-naming-in-validator branch February 23, 2018 02:47
@yordis
Copy link
Contributor

yordis commented Feb 23, 2018

@afbresley @alexdovzhanyn I think you should be using ? when it gives you a boolean back, is_ when you should be checking some branches like you are doing right now.

@yordis
Copy link
Contributor

yordis commented Feb 23, 2018

@afbresley @alexdovzhanyn from Credo

 [R] ↗ Predicate function names should not start with 'is', and should end in a
┃       question mark.
┃       lib/ledger.ex:44 #(UltraDark.Ledger.is_empty?)

@alexdovzhanyn
Copy link
Owner

@afbresley @yordis fair enough, credo pretty explicitly sets the standard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistent function naming in Validator
3 participants