Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent function naming in Validator #35

Closed
zac-garby opened this issue Feb 22, 2018 · 1 comment · Fixed by #36
Closed

Consistent function naming in Validator #35

zac-garby opened this issue Feb 22, 2018 · 1 comment · Fixed by #36
Assignees
Labels
Good First Issue Good for newcomers Help Wanted Extra attention is needed

Comments

@zac-garby
Copy link
Contributor

In the validator, some functions end in question marks and some don't, where really they all should or they all shouldn't. For example, there's valid_hash/1 and valid_coinbase?/1. They both check if something's valid, but aren't consistent in their names.

@zac-garby zac-garby added the Good First Issue Good for newcomers label Feb 22, 2018
@alexdovzhanyn alexdovzhanyn added the Help Wanted Extra attention is needed label Feb 22, 2018
@afbreilyn afbreilyn self-assigned this Feb 23, 2018
@afbreilyn
Copy link
Contributor

I think if the function only returns a boolean, then the question mark is appropriate. I'll follow this paradigm as I edit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good for newcomers Help Wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants