Pax | Switching key to u8 and update on Pax header doc header #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This might not be recommended since key() converts the key into str. Writing the key through str might me more straight forward in the long run |
cgwalters
requested changes
Nov 25, 2024
| @@ -156,7 +156,7 @@ impl<T: Write> crate::Builder<T> { | |||
| /// Returns io::Error if an error occurs, else it returns () | |||
| pub fn append_pax_extensions<'key, 'value>( | |||
| &mut self, | |||
| headers: impl IntoIterator<Item = (&'key str, &'value [u8])>, | |||
| headers: impl IntoIterator<Item = (&'key [u8], &'value [u8])>, | |||
There was a problem hiding this comment.
Unfortunately we already published the previous PR, we can't break the API. We could add a new one...but I'm not sure, maybe we only do it if there's an actual use case?
There was a problem hiding this comment.
Yes, it's better like that I think.
If needed one day, this PR could be merged to fix the issue later
gwitrand-ovh
force-pushed
the
pax_cleanup
branch
from
7accbdb
to
0346477
Compare
gwitrand-ovh
force-pushed
the
pax_cleanup
branch
from
0346477
to
c37a518
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following PR #382 comments