-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ability to customize the prefix of the statemachine name #223
add ability to customize the prefix of the statemachine name #223
Conversation
Just drafting a PR to see what you think of the implementation. Have not addressed the Terraform changes yet. |
I am not real familiar with Terraform but it looks like we could actually have a similar functionality by giving the statemachine a name_prefix instead of If that's the case, I think we just need to update this line |
Thanks @TonySherman, this looks great 🚀 @ldcorentin any chance you can share your feedback on the Terraform side of things? 😄 |
@TonySherman I have added I would also play with As for the documentation (here): A name must not contain:
- white space
- brackets < > { } [ ]
- wildcard characters ? *
- special characters " # % \ ^ | ~ ` $ & , ; : /
- control characters (U+0000-001F, U+007F-009F) |
06e996a
to
91b7dd5
Compare
I think the regex pattern I added should meet those requirements by limiting to alphanumeric characters. |
@TonySherman I've done a few minor things:
It if all makes sense to you, I'll be happy to merge this PR :) (don't worry about the failing integration test, it's an auth error on my side) |
Also, I've realized we only have 43 characters for the prefix (not 44), since we're using one for the |
Good catch on the character count and the characters I missed! 😂 Those changes all look great to me! Really nice working with you on this! |
This will address #220, allowing customized prefixes for the StateMachine name.
It is defaulted to the original name
powerTuningStateMachine
but the appended id will be slightly longer.Current default:
powerTuningStateMachine-8WZnCEWFsLBW
This PR changes the default to:
powerTuningStateMachine-7c304ce0-a4ff-11ee-89b2-0ea1c2170c63
and allows the customized prefix:
myCustomPrefix-7c304ce0-a4ff-11ee-89b2-0ea1c2170c63