Fix createHeadTags infinite loop when your themes don't override the …

…headTags property
alexandrevryghem · Aug 6, 2023 · e4b386b · e4b386b
1 parent 873a8e1
commit e4b386b
Showing 1 changed file with 1 addition and 11 deletions.
diff --git a/src/app/app.component.ts b/src/app/app.component.ts
@@ -316,14 +316,7 @@ export class AppComponent implements OnInit, AfterViewInit {
       if (hasValue(parentThemeName)) {
         // inherit the head tags of the parent theme
         return this.createHeadTags(parentThemeName);
-      }
-      const defaultThemeConfig = getDefaultThemeConfig();
-      const defaultThemeName = defaultThemeConfig.name;
-      if (
-        hasNoValue(defaultThemeName) ||
-        themeName === defaultThemeName ||
-        themeName === BASE_THEME_NAME
-      ) {
+      } else {
         // last resort, use fallback favicon.ico
         return [
           this.createHeadTag({
@@ -336,9 +329,6 @@ export class AppComponent implements OnInit, AfterViewInit {
           })
         ];
       }
-
-      // inherit the head tags of the default theme
-      return this.createHeadTags(defaultThemeConfig.name);
     }
 
     return headTagConfigs.map(this.createHeadTag.bind(this));