111731: Fixed accessibility issues

alexandrevryghem · May 5, 2024 · 58d7387 · 58d7387
1 parent 8064300
commit 58d7387
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/src/app/shared/search/advanced-search/advanced-search.component.html b/src/app/shared/search/advanced-search/advanced-search.component.html
@@ -1,14 +1,21 @@
 <h3>{{ 'search.sidebar.advanced-search.title' | translate }}</h3>
 <div class="advanced-search b-3 p-3">
-  <h5>{{ 'search.sidebar.advanced-search.filter-by' | translate }}</h5>
+  <h4>{{ 'search.sidebar.advanced-search.filter-by' | translate }}</h4>
+  <label class="sr-only" for="advanced-search-filters">
+    {{ 'search.sidebar.advanced-search.filters' | translate }}
+  </label>
   <select [(ngModel)]="currentFilter" (keyup.enter)="applyFilter()"
           (ngModelChange)="currentOperator = advancedFilterMap.get(currentFilter).operators[0].operator"
-          class="form-control mb-2">
+          class="form-control mb-2" id="advanced-search-filters">
     <option *ngFor="let advancedFilter of (advancedFilters$ | async) | keyvalue" [value]="advancedFilter.value.filter">
       {{ 'search.filters.filter.' + advancedFilter.value.filter + '.head' | translate }}
     </option>
   </select>
-  <select [(ngModel)]="currentOperator" (keyup.enter)="applyFilter()" class="form-control mb-2">
+  <label class="sr-only" for="advanced-search-operators">
+    {{ 'search.sidebar.advanced-search.operators' | translate }}
+  </label>
+  <select [(ngModel)]="currentOperator" (keyup.enter)="applyFilter()"
+          class="form-control mb-2" id="advanced-search-operators">
     <option *ngFor="let operator of advancedFilterMap.get(currentFilter)?.operators" [value]="operator.operator">
       {{ 'search.filters.operator.' + operator.operator + '.text' | translate }}
     </option>

diff --git a/src/assets/i18n/en.json5 b/src/assets/i18n/en.json5
@@ -3912,6 +3912,10 @@
 
   "search.sidebar.advanced-search.filter-by": "Filter by",
 
+  "search.sidebar.advanced-search.filters": "Filters",
+
+  "search.sidebar.advanced-search.operators": "Operators",
+
   "search.sidebar.advanced-search.add": "Add",
 
   "search.sidebar.settings.title": "Settings",