Prevent /api/eperson/profiles/{userId} to be called when unauthenticated

alexandrevryghem · Mar 17, 2024 · 2123c3b · 2123c3b
1 parent 9a7e43c
commit 2123c3b
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/app/notifications/suggestions.service.ts b/src/app/notifications/suggestions.service.ts
@@ -38,6 +38,7 @@ import {
 import { WorkspaceItem } from '../core/submission/models/workspaceitem.model';
 import { WorkspaceitemDataService } from '../core/submission/workspaceitem-data.service';
 import {
+  hasNoValue,
   hasValue,
   isNotEmpty,
 } from '../shared/empty.util';
@@ -165,6 +166,9 @@ export class SuggestionsService {
    *   The EPerson id for which to retrieve suggestion targets
    */
   public retrieveCurrentUserSuggestions(userUuid: string): Observable<SuggestionTarget[]> {
+    if (hasNoValue(userUuid)) {
+      return of([]);
+    }
     return this.researcherProfileService.findById(userUuid, true).pipe(
       getFirstCompletedRemoteData(),
       mergeMap((profile: RemoteData<ResearcherProfile> ) => {