Set requireUserVerification to false during registration and authentication flow #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradpurchase
changed the title
bradpurchase
changed the title
alexanderson1993
approved these changes
Jun 4, 2024
|
Published as 0.3.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #18 to set
requireUserVerification: falseon theverifyRegistrationResponseandverifyAuthenticationResponseso that it actually uses theuserVerificationpreference, as per: https://github.com/MasterKale/SimpleWebAuthn/blob/a169def3c663cb671cdc6bc6e00a4993944a61ae/packages/server/src/authentication/verifyAuthenticationResponse.ts#L210This properly fixes the issue outlined in #18, where the following error is presented on registration or authentication if the user verification method is not available (i.e. Macbook is in clamshell mode and TouchID is not available):
"User verification required, but user could not be verified".