Prepend prefix to all ids to guarantee that they are unique #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any news about this/ Patch has been around for 9 months without any positive or negative feedback. I would definitely find it useful to have uinique ids/labels as I'm getting the following when documenting many Argparse instances in one .rst document: |
wlupton
force-pushed
the
feature/ensure-unique-ids
branch
from
5591a2c to
2c554c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was including documentation for more than one python problem in the same file, and found that the ids were not unique, e.g.:
The suggested fix derives a prefix from
func,refetc. and passes it toensureUniqueIDs(), which then unconditionally prefixes it to all ids to give, e.g.:I realise it might be better to use a separate (new) function for doing this rather than overloading
ensureUniqueIDs(), and would be happy to make this change.