Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/key oid candid alerts #378

Merged
merged 16 commits into from
Jan 17, 2024
Merged

Conversation

AlxEnashi
Copy link
Contributor

Summary of the changes

Changed al uses of drop duplicates in detections and non detections dataframes by candid to by candid and oid.
Changed criteria for non detections insert in correctino step.

Observations

<-- Add some notes to keep in mind !-->

Components that need updates and steps to follow

Pull from the changes to scribe and db.
#377

About this PR:

  • You added the necessary documentation for the team to understand your work.
  • You linked this PR to the corresponding issue or user story.
  • Your changes fulfill the Definition of Done of the issue or user story.
  • Your changes were tested with manual testing before being submitted.
  • Your changes were tested with automatic unit tests.
  • Your changes were tested with automatic integration tests.

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (efc57d6) 86.52% compared to head (6d0786a) 79.75%.
Report is 51 commits behind head on main.

❗ Current head 6d0786a differs from pull request most recent head c672564. Consider uploading reports for the commit c672564 to get more accurate results

Files Patch % Lines
correction_step/correction/core/corrector.py 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
- Coverage   86.52%   79.75%   -6.77%     
==========================================
  Files          35       19      -16     
  Lines        1670      741     -929     
==========================================
- Hits         1445      591     -854     
+ Misses        225      150      -75     
Flag Coverage Δ
unittest 79.75% <95.00%> (-6.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dirodriguezm
Copy link
Contributor

Will merge this and the feature step will be fixed on a follow up PR

@dirodriguezm dirodriguezm merged commit 7c6657c into main Jan 17, 2024
19 of 23 checks passed
@dirodriguezm dirodriguezm deleted the refactor/key_oid_candid_alerts branch January 17, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [Metadata Step] Hay objetos que se intentan agregar con otro oid del que existe previamente en detection
2 participants