-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/key oid candid alerts #378
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #378 +/- ##
==========================================
- Coverage 86.52% 79.75% -6.77%
==========================================
Files 35 19 -16
Lines 1670 741 -929
==========================================
- Hits 1445 591 -854
+ Misses 225 150 -75
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…/key_oid_candid_alerts
…/key_oid_candid_alerts
…ker/pipeline into refactor/key_oid_candid_alerts
…/key_oid_candid_alerts
…/key_oid_candid_alerts
…/key_oid_candid_alerts
Will merge this and the feature step will be fixed on a follow up PR |
Summary of the changes
Changed al uses of drop duplicates in detections and non detections dataframes by candid to by candid and oid.
Changed criteria for non detections insert in correctino step.
Observations
<-- Add some notes to keep in mind !-->
Components that need updates and steps to follow
Pull from the changes to scribe and db.
#377
About this PR: