Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magstats step using oid #366

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Magstats step using oid #366

merged 3 commits into from
Jan 2, 2024

Conversation

AlxEnashi
Copy link
Contributor

@AlxEnashi AlxEnashi commented Jan 2, 2024

Summary of the changes

Changed the calculators to group by oid instead of aid

About this PR:

  • You added the necessary documentation for the team to understand your work.
  • You linked this PR to the corresponding issue or user story.
  • Your changes fulfill the Definition of Done of the issue or user story.
  • Your changes were tested with manual testing before being submitted.
  • Your changes were tested with automatic unit tests.
  • Your changes were tested with automatic integration tests.

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (aab2d2e) 75.09% compared to head (7d210ea) 97.11%.
Report is 27 commits behind head on main.

Files Patch % Lines
magstats_step/magstats_step/step.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #366       +/-   ##
===========================================
+ Coverage   75.09%   97.11%   +22.02%     
===========================================
  Files           8        5        -3     
  Lines         277      243       -34     
===========================================
+ Hits          208      236       +28     
+ Misses         69        7       -62     
Flag Coverage Δ
unittest 97.11% <83.33%> (+22.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dirodriguezm dirodriguezm merged commit eecf416 into main Jan 2, 2024
6 checks passed
@dirodriguezm dirodriguezm deleted the refactor/magstat_using_oid branch January 2, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Magstats Step cambiar join por oid Magstats Step Crear indice por oid luego de calcular magstats
2 participants