Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(magstats-step): calculate deltajd #307

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Conversation

dirodriguezm
Copy link
Contributor


Summary of the changes

Adds method to calculate deltajd.

Updates mongo object model with deltajd field

Closes #306

About this PR:

  • You added the necessary documentation for the team to understand your work.
  • You linked this PR to the corresponding issue or user story.
  • Your changes fulfill the Definition of Done of the issue or user story.
  • Your changes were tested with manual testing before being submitted.
  • Your changes were tested with automatic unit tests.
  • Your changes were tested with automatic integration tests.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (b0e0774) 60.89% compared to head (0c4e3ff) 66.59%.
Report is 40 commits behind head on main.

❗ Current head 0c4e3ff differs from pull request most recent head 6b794db. Consider uploading reports for the commit 6b794db to get more accurate results

Files Patch % Lines
lightcurve-step/lightcurve_step/step.py 0.00% 4 Missing ⚠️
libs/db-plugins/db_plugins/db/mongo/models.py 0.00% 1 Missing ⚠️
magstats_step/magstats_step/core/magstats.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
+ Coverage   60.89%   66.59%   +5.70%     
==========================================
  Files           3       23      +20     
  Lines         179     1443    +1264     
==========================================
+ Hits          109      961     +852     
- Misses         70      482     +412     
Flag Coverage Δ
unittest 66.59% <88.67%> (+5.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dirodriguezm dirodriguezm merged commit 7666c8d into main Nov 30, 2023
26 checks passed
@dirodriguezm dirodriguezm deleted the feat/calculate-deltajd branch November 30, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MagstatsStep] Add deltamjd object statistic
1 participant