goodbye messi TEST_MESSI_HEADER_QUANTILES_PATH

alercebroker · Aug 20, 2024 · 4c34553 · 4c34553
1 parent ce7da4b
commit 4c34553
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 9 deletions.
diff --git a/.github/workflows/apf.yaml b/.github/workflows/apf.yaml
@@ -150,7 +150,6 @@ jobs:
       TEST_BALTO_MODEL_PATH: "${{ secrets.TEST_BALTO_MODEL_PATH }}"
       TEST_BALTO_QUANTILES_PATH: "${{ secrets.TEST_BALTO_QUANTILES_PATH }}"
       TEST_MESSI_MODEL_PATH: "${{ secrets.TEST_MESSI_MODEL_PATH }}"
-      TEST_MESSI_HEADER_QUANTILES_PATH: "${{ secrets.TEST_MESSI_HEADER_QUANTILES_PATH }}"
       TEST_MESSI_FEATURE_QUANTILES_PATH: "${{ secrets.TEST_MESSI_FEATURE_QUANTILES_PATH }}"
       TEST_TORETTO_MODEL_PATH: "${{ secrets.TEST_TORETTO_MODEL_PATH }}"
       TEST_BARNEY_MODEL_PATH: "${{ secrets.TEST_BARNEY_MODEL_PATH }}"
@@ -169,7 +168,6 @@ jobs:
       TEST_BALTO_MODEL_PATH: "${{ secrets.TEST_BALTO_MODEL_PATH }}"
       TEST_BALTO_QUANTILES_PATH: "${{ secrets.TEST_BALTO_QUANTILES_PATH }}"
       TEST_MESSI_MODEL_PATH: "${{ secrets.TEST_MESSI_MODEL_PATH }}"
-      TEST_MESSI_HEADER_QUANTILES_PATH: "${{ secrets.TEST_MESSI_HEADER_QUANTILES_PATH }}"
       TEST_MESSI_FEATURE_QUANTILES_PATH: "${{ secrets.TEST_MESSI_FEATURE_QUANTILES_PATH }}"
       TEST_TORETTO_MODEL_PATH: "${{ secrets.TEST_TORETTO_MODEL_PATH }}"
       TEST_BARNEY_MODEL_PATH: "${{ secrets.TEST_BARNEY_MODEL_PATH }}"

diff --git a/.github/workflows/lc_classification_step.yaml b/.github/workflows/lc_classification_step.yaml
@@ -26,7 +26,6 @@ jobs:
       TEST_BALTO_MODEL_PATH: "${{ secrets.TEST_BALTO_MODEL_PATH }}"
       TEST_BALTO_QUANTILES_PATH: "${{ secrets.TEST_BALTO_QUANTILES_PATH }}"
       TEST_MESSI_MODEL_PATH: "${{ secrets.TEST_MESSI_MODEL_PATH }}"
-      TEST_MESSI_HEADER_QUANTILES_PATH: "${{ secrets.TEST_MESSI_HEADER_QUANTILES_PATH }}"
       TEST_MESSI_FEATURE_QUANTILES_PATH: "${{ secrets.TEST_MESSI_FEATURE_QUANTILES_PATH }}"
       TEST_TORETTO_MODEL_PATH: "${{ secrets.TEST_TORETTO_MODEL_PATH }}"
       TEST_MLP_MODEL_PATH: "${{ secrets.TEST_MLP_MODEL_PATH }}"
@@ -50,7 +49,6 @@ jobs:
       TEST_BALTO_MODEL_PATH: "${{ secrets.TEST_BALTO_MODEL_PATH }}"
       TEST_BALTO_QUANTILES_PATH: "${{ secrets.TEST_BALTO_QUANTILES_PATH }}"
       TEST_MESSI_MODEL_PATH: "${{ secrets.TEST_MESSI_MODEL_PATH }}"
-      TEST_MESSI_HEADER_QUANTILES_PATH: "${{ secrets.TEST_MESSI_HEADER_QUANTILES_PATH }}"
       TEST_MESSI_FEATURE_QUANTILES_PATH: "${{ secrets.TEST_MESSI_FEATURE_QUANTILES_PATH }}"
       TEST_TORETTO_MODEL_PATH: "${{ secrets.TEST_TORETTO_MODEL_PATH }}"
       TEST_MLP_MODEL_PATH: "${{ secrets.TEST_MLP_MODEL_PATH }}"

diff --git a/.github/workflows/poetry-tests-template.yaml b/.github/workflows/poetry-tests-template.yaml
@@ -43,9 +43,6 @@ on:
       TEST_MESSI_MODEL_PATH:
         required: false
         description: 'A path to a .pt file'
-      TEST_MESSI_HEADER_QUANTILES_PATH:
-        required: false
-        description: 'A path to the directory containing joblib files for messi'
       TEST_MESSI_FEATURE_QUANTILES_PATH:
         required: false
         description: 'A path to the directory containing joblib files for messi'
@@ -87,7 +84,6 @@ jobs:
       TEST_BALTO_MODEL_PATH: ${{ secrets.TEST_BALTO_MODEL_PATH }}
       TEST_BALTO_QUANTILES_PATH: ${{ secrets.TEST_BALTO_QUANTILES_PATH }}
       TEST_MESSI_MODEL_PATH: ${{ secrets.TEST_MESSI_MODEL_PATH }}
-      TEST_MESSI_HEADER_QUANTILES_PATH: ${{ secrets.TEST_MESSI_HEADER_QUANTILES_PATH }}
       TEST_MESSI_FEATURE_QUANTILES_PATH: ${{ secrets.TEST_MESSI_FEATURE_QUANTILES_PATH }}
       TEST_TORETTO_MODEL_PATH: ${{ secrets.TEST_TORETTO_MODEL_PATH }}
       TEST_BARNEY_MODEL_PATH: ${{ secrets.TEST_BARNEY_MODEL_PATH }}

diff --git a/lc_classification_step/tests/unit/conftest.py b/lc_classification_step/tests/unit/conftest.py
@@ -368,7 +368,7 @@ def test_model(factory, messages_ztf):
 
         # Test producer produces correct data
         calls = step.producer.mock_calls
-        assert len(calls) == len(messages_ztf) + 1  # beause call __del__
+        assert len(calls) == len(messages_ztf) + 1  # because call __del__
         for call in calls:
             if len(call.args) > 1:  # because of __del__
                 obj = call.args[0]