Skip to content

Commit

Permalink
Merge pull request #57 from alercebroker/scribe/kafka-auth
Browse files Browse the repository at this point in the history
feat: add option to use kafka authentication on scribe
  • Loading branch information
dirodriguezm authored Mar 10, 2023
2 parents 5bce2d3 + 45d9912 commit 6e1f814
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 2 deletions.
2 changes: 1 addition & 1 deletion charts/scribe/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.0
version: 0.2.0

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
13 changes: 12 additions & 1 deletion charts/scribe/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,18 @@ spec:
value: "{{ .Values.secrets.mockDb }}"
- name: MONGODB_SECRET_NAME
value: "{{ .Values.secrets.secretName }}"

{{- if .Values.secrets.kafkaAuth.enabled }}
- name: KAFKA_USERNAME
valueFrom:
secretKeyRef:
name: kafka-auth
key: username
- name: KAFKA_PASSWORD
valueFrom:
secretKeyRef:
name: kafka-auth
key: password
{{- end }}
{{- with .Values.affinity }}
affinity:
{{- toYaml . | nindent 8 }}
Expand Down
8 changes: 8 additions & 0 deletions charts/scribe/templates/secrets.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
apiVersion: v1
kind: Secret
metadata:
name: kafka-auth
namespace: {{ .Values.namespace }}
stringData:
username: {{ .Values.secrets.kafkaAuth.username }}
password: {{ .Values.secrets.kafkaAuth.password }}
4 changes: 4 additions & 0 deletions charts/scribe/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -54,3 +54,7 @@ secrets:
mockDb: "True"
#secretName: name of the secret stored in AWS Secret Manager containing MongoDB credentials
secretName: ""
kafkaAuth:
enabled: false
username: ""
password: ""

0 comments on commit 6e1f814

Please sign in to comment.