Fixed setup.py for apple silicon #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a check if using mac with arm chip (apple silicon) to modify compiler_args suggested in alercebroker/mhps#3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using the
platformpackage to check if the system is a Mac with Apple silicon, and if yes, modifyingcompiler_argsas suggested by @ignacioreyes in alercebroker/mhps#3.It worked for me on a 14" MacBook Pro 2021 (M1 Pro). I believe this is a general solution, but in case it's incompatible with the rest of the project, feel free to edit/scrap accordingly.