Frequencies tk #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are a few other things that I am not quite sure I am not 100% sure how token_frequency should be used for estimating the importance / specificity of a term. Document frequency and inverse document frequency for sure. However, not quite sure what would be the best way to define N for the IDF formula. Maybe another counter for the WordFrequency class? Kind of like n_items, but for number of documents, rather than number of terms. Let me know peoples thoughts on whether this makes sense. |
|
"some idf changes" is just me trying around how the idf could be calculated. Sadly I can't really run a proper test as my data is a bit limited. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commits are about a small change I had to make in order to create the frequency files. Due to the previous ordering, line 198 was tyring to call .save on a document that was a dictionary.