Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for --atomic #304

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TomaszBelina
Copy link

@TomaszBelina TomaszBelina commented Jul 15, 2021

The change adds atomicPush property to plugin configuration. If set to true --atomic option is added to git command line.

@aleksandr-m
Copy link
Owner

@TomaszBelina Do you have a real use-case for that? For me if some push fails, I would probably resolve it manually and not pushing what is already ok is less work to do.

@mmusenbr
Copy link

I would have a use-case for this: CI. We trigger everything via CI. So if eg the merge into dev in the later stage of the process fails, I would not only need to resolve that merge failure, but also cleanup everything what has already happened.
But to keep to current workflow/functionality I would suggest to do it encapsulated in gitPush/gitPushDelete and either store it or push it immediately.

@aleksandr-m
Copy link
Owner

@redeamer Not sure I understand the need to clean something up after fail. E.g. you are running the goal with two pushes and second one fails, then resolution is probably as simple as resolve conflicts, merge, delete branch. Or maybe creating some PR with hotfix which can be merged in CI.

And even if you do need to do some cleaning, I cannot see how atomic will change this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants