Adds release-finish check for remotes #171
Conversation
|
@jam01 Can you provide more information. Why do you care if there is a release branch somewhere? Why don't you use release branch to trigger CI builds? And you need to fetch before checking remote in this way. |
|
Sure. We already have the release branch commit trigger the CI. The issue we're having is that some releases may still be done manually and may not use the plugin, possibly leaving a release branch open.
Sent from ProtonMail mobile
…-------- Original Message --------
On Apr 16, 2019, 2:44 PM, Aleksandr Mashchenko wrote:
***@***.***(https://github.com/jam01) Can you provide more information. Why do you care if there is a release branch somewhere? Why don't you use release branch to trigger CI builds?
And you need to fetch before checking remote in this way.
—
You are receiving this because you were mentioned.
Reply to this email directly, [view it on GitHub](#171 (comment)), or [mute the thread](https://github.com/notifications/unsubscribe-auth/AJoCFKwiL-IL5Jx7ccsSl3NXvBNatWztks5vhigDgaJpZM4crEHf).
|
|
I think this would encourage devs to use the plugin since the CI would correctly stop misuse of the the branching strategy Perhaps a similar check should be done for opening releases. A dev could open a release just to try to get some feature through UAT without checking that there was already another release ongoing. |
|
Please help me on this. [INFO] ------------------------------------------------------------------------ C:\Users\Shivansh\Downloads\gitflow-maven-plugin-master\gitflow-maven-plugin-master>mvn -B gitflow:release-start gitflow:release-finish |
Adds remotes when checking that no other release branches exist. This is important when using in a CI server context where automated builds will only checkout a single branch when triggered.
Open to feedback :)