Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

docs: improve definition of a Backup #5316

Merged
merged 4 commits into from
May 22, 2024
Merged

Conversation

OrhanTozan
Copy link
Contributor

@OrhanTozan OrhanTozan commented May 5, 2024

After some building, I realized that a backup is a snapshot of a resource, not the whole m365 service. Initially, I assumed that 1 backup takes the whole service per tenant (https://discord.com/channels/1022200980487557130/1022200981376745474/1231385151376719892). This doc update should help clear the confusion more.

Maybe there is a better way to word it, so any other suggestions are welcome.


Does this PR need a docs update or release note?

  • ✅ Yes, it's included
  • 🕐 Yes, but in a later PR
  • ⛔ No

Type of change

  • 🌻 Feature
  • 🐛 Bugfix
  • 🗺️ Documentation
  • 🤖 Supportability/Tests
  • 💻 CI/Deployment
  • 🧹 Tech Debt/Cleanup

Issue(s)

  • #

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

Copy link
Contributor

aviator-app bot commented May 5, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@CLAassistant
Copy link

CLAassistant commented May 5, 2024

CLA assistant check
All committers have signed the CLA.

@OrhanTozan OrhanTozan changed the title Improve definition of a Backup docs: improve definition of a Backup May 5, 2024
Copy link
Contributor

@ashmrtn ashmrtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the docs update! Sorry it took a bit for someone to get around to it

website/docs/setup/concepts.md Outdated Show resolved Hide resolved
@OrhanTozan
Copy link
Contributor Author

@ashmrtn no problem, I added your apostrophe suggestion btw.

@OrhanTozan
Copy link
Contributor Author

OrhanTozan commented May 22, 2024

@ashmrtn any idea why the build fails? It's only a textual docs change.

@ashmrtn
Copy link
Contributor

ashmrtn commented May 22, 2024

Sorry! I forgot GH can be weird about displaying actions sometimes. Looks like a line too long linting error

docs/setup/concepts.md:26:121 MD013/line-length Line length [Expected: 120; Actual: 138]

If you want to run the linter locally there's directions in a README in the website folder as well 😄

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@OrhanTozan
Copy link
Contributor Author

@ashmrtn aha, ok. I couldn't find that error in the logs.

I fixed the line length.

@ashmrtn ashmrtn merged commit d9d993d into alcionai:main May 22, 2024
25 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants