Source side implementation

[edurenye]

Rebased the pull #172 , just trying to speed up issue #4

[albfan]

Will review today, thanks for working on this.

Btw, there's an initiative under GNOME based on miracast.

https://github.com/benzea/gnome-screencast

Take a look and join us if you want to see this feature on your laptop

[Arzte]

@albfan Did you ever get a chance to review this PR?

(sorry if I'm being a bother here, just been a few days)

[albfan]

Sorry, didn't get to review it yet. Hope to do soon

[albfan]

@edurenye finally reviewing this. I set up a Docker container to build miraclecast 3a459e5. Build is passing on master. Nice!

I have:

• rebased your changes https://github.com/albfan/miraclecast/commits/wip/edurenye/source-side
• removed broken buildsystems 3c14d52
• added new dependencies for vala 67020ad
• and fix specific problems for cmake on docker 3ba1d1e

but this PR do not compile for me. does it for you? You can check build output here: https://semaphoreci.com/albfan/miraclecast-2/branches/wip-edurenye-source-side/builds/5

cmake output

-- The C compiler identification is GNU 8.2.0
-- The CXX compiler identification is GNU 8.2.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.29") 
-- Checking for module 'glib-2.0'
--   Found glib-2.0, version 2.58.1
-- Checking for module 'libudev'
--   Found libudev, version 239
-- Checking for module 'libsystemd'
--   Found libsystemd, version 239
-- Checking for module 'gstreamer-1.0'
--   Found gstreamer-1.0, version 1.14.4
-- Checking for module 'gstreamer-base-1.0'
--   Found gstreamer-base-1.0, version 1.14.4
-- Checking for module 'systemd>=213'
--   Found systemd, version 239
-- Found Readline: /usr/include  
-- Compiling with Readline support
-- Compiling with Readline support
-- Found Vala: /usr/bin/valac  
-- Checking for module 'gio-2.0'
--   Found gio-2.0, version 2.58.1
-- Checking for module 'gdk-3.0'
--   Found gdk-3.0, version 3.24.2
-- Checking for module 'gstreamer-1.0'
--   Found gstreamer-1.0, version 1.14.4
-- Checking for module 'check'
--   No package 'check' found
-- Configuring done
-- Generating done
-- Build files have been written to: /source/build-cmake
Scanning dependencies of target miracle-shared
[  1%] Building C object src/shared/CMakeFiles/miracle-shared.dir/rtsp.c.o
[  3%] Building C object src/shared/CMakeFiles/miracle-shared.dir/shl_htable.c.o
[  5%] Building C object src/shared/CMakeFiles/miracle-shared.dir/shl_log.c.o
[  7%] Building C object src/shared/CMakeFiles/miracle-shared.dir/shl_ring.c.o
[  9%] Building C object src/shared/CMakeFiles/miracle-shared.dir/shl_util.c.o
[ 11%] Building C object src/shared/CMakeFiles/miracle-shared.dir/wpas.c.o
[ 12%] Linking C static library libmiracle-shared.a
[ 12%] Built target miracle-shared
Scanning dependencies of target miracled
[ 14%] Building C object src/CMakeFiles/miracled.dir/miracled.c.o
[ 16%] Linking C executable miracled
[ 16%] Built target miracled
Scanning dependencies of target miracle-wifid
[ 18%] Building C object src/wifi/CMakeFiles/miracle-wifid.dir/wifid.c.o
[ 20%] Building C object src/wifi/CMakeFiles/miracle-wifid.dir/wifid-dbus.c.o
[ 22%] Building C object src/wifi/CMakeFiles/miracle-wifid.dir/wifid-link.c.o
/source/src/wifi/wifid-link.c: In function 'link_set_config_methods':
/source/src/wifi/wifid-link.c:393:1: error: expected declaration or statement at end of input
 }
 ^
At top level:
/source/src/wifi/wifid-link.c:387:6: warning: 'link_supplicant_p2p_scan_changed' defined but not used [-Wunused-function]
 void link_supplicant_p2p_scan_changed(struct link *l, bool new_value)
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/source/src/wifi/wifid-link.c:374:6: warning: 'link_supplicant_stopped' defined but not used [-Wunused-function]
 void link_supplicant_stopped(struct link *l)
      ^~~~~~~~~~~~~~~~~~~~~~~
/source/src/wifi/wifid-link.c:359:6: warning: 'link_supplicant_started' defined but not used [-Wunused-function]
 void link_supplicant_started(struct link *l)
      ^~~~~~~~~~~~~~~~~~~~~~~
/source/src/wifi/wifid-link.c:351:13: warning: 'link_get_mac_addr' defined but not used [-Wunused-function]
 const char *link_get_mac_addr(struct link *l)
             ^~~~~~~~~~~~~~~~~
/source/src/wifi/wifid-link.c:337:6: warning: 'link_get_p2p_scanning' defined but not used [-Wunused-function]
 bool link_get_p2p_scanning(struct link *l)
      ^~~~~~~~~~~~~~~~~~~~~
/source/src/wifi/wifid-link.c:321:5: warning: 'link_set_p2p_scanning' defined but not used [-Wunused-function]
 int link_set_p2p_scanning(struct link *l, bool set)
     ^~~~~~~~~~~~~~~~~~~~~
/source/src/wifi/wifid-link.c:313:13: warning: 'link_get_wfd_subelements' defined but not used [-Wunused-function]
 const char *link_get_wfd_subelements(struct link *l)
             ^~~~~~~~~~~~~~~~~~~~~~~~
/source/src/wifi/wifid-link.c:283:5: warning: 'link_set_wfd_subelements' defined but not used [-Wunused-function]
 int link_set_wfd_subelements(struct link *l, const char *val)
     ^~~~~~~~~~~~~~~~~~~~~~~~
/source/src/wifi/wifid-link.c:275:13: warning: 'link_get_friendly_name' defined but not used [-Wunused-function]
 const char *link_get_friendly_name(struct link *l)
             ^~~~~~~~~~~~~~~~~~~~~~
/source/src/wifi/wifid-link.c:221:5: warning: 'link_renamed' defined but not used [-Wunused-function]
 int link_renamed(struct link *l, const char *ifname)
     ^~~~~~~~~~~~
/source/src/wifi/wifid-link.c:208:6: warning: 'link_supplicant_p2p_state_known' defined but not used [-Wunused-function]
 void link_supplicant_p2p_state_known(struct link *l, int state)
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/source/src/wifi/wifid-link.c:184:5: warning: 'link_manage' defined but not used [-Wunused-function]
 int link_manage(struct link *l, bool set)
     ^~~~~~~~~~~
/source/src/wifi/wifid-link.c:179:6: warning: 'link_get_managed' defined but not used [-Wunused-function]
 bool link_get_managed(struct link *l)
      ^~~~~~~~~~~~~~~~
/source/src/wifi/wifid-link.c:174:5: warning: 'link_get_p2p_state' defined but not used [-Wunused-function]
 int link_get_p2p_state(struct link *l)
     ^~~~~~~~~~~~~~~~~~
make[2]: *** [src/wifi/CMakeFiles/miracle-wifid.dir/build.make:89: src/wifi/CMakeFiles/miracle-wifid.dir/wifid-link.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:218: src/wifi/CMakeFiles/miracle-wifid.dir/all] Error 2
make: *** [Makefile:130: all] Error 2

Please rebase your PR and grab those CI changes. You can run docker locally with:

docker build -t miraclecast-image .

[albfan]

btw: there's a https://github.com/albfan/miraclecast/tree/derekdai-master-squashed where I squashed all the back and forth in derekdai fork. Maybe rebase that branch would be a better option

[AtesComp]

The error is as listed:

/source/src/wifi/wifid-link.c: In function 'link_set_config_methods':
/source/src/wifi/wifid-link.c:393:1: error: expected declaration or statement at end of input
 }
 ^

In file "src/wifi/wifid-link.c" at line 173 there is no ending "}" for function "link_set_config_methods"
Adding fixes compile.

[AtesComp]

I compiled with autotools and seemed to finish ok, but it didn't compile the dispctl tool.

I then used cmake and the compile failed because the src/disp CMakeList.txt file needs directives for GLIB2 includes and libs.

[albfan]

@AtesComp that kind of fixes are on my squashed branch 56f9d44, that's why doesn't make much sense to me to keep this MR open. code do not even compile

[AtesComp]

Its hard to tell which particular branch you continue to reference as it doesn't show up in the branch listing since its not named. It's also is difficult to tell which branch is the most up to date. So please make this repository make sense. Are you referring to the "docker" branch or "56f9d44b19"?

Please update the readme file for your prefered branch with updated instructions for the operational use of the software--the use of dispctl in the "documentation" section.

[AtesComp]

I suppose you mean the "derekdai-master-squashed" branch which shows up as "stale". If this is the branch, please update the readme there.

[albfan]

Update README?

[AtesComp]

Yes, the README.md file. In this or the derickdai-master-squashed branch (I've switched). The "Documentation" section lists steps for sink and peer, but these branches used the miraclecast-dispd and miraclecast-wifid services to automate switching NetworkManager with dbus. Also, miracle-dispctl (and miracle-wifictl) need updated documentation there.

[albfan]

There're lot of noise in @derekdai PR. I just squashed to avoid rebase things like enable audio, disable audio which happens in that fork, but in the end I need to patch it, so I just want to notice that. It is supposed implementation should keep reviews and rework there in #172, but it stops to get progress so I guess we are not in a step where we can update docs about how it should work.

The whole idea is to enable Wifi Direct (through a dbus setting that could be trigger in gnome-control-center at some point) so you save battery when not using miracast, and then enable miracast where a service like miracle-dispd manages everything.

I'm collapsing this days comments with long output with <details></details> so one could follow comments on PR, where all the info about it should be avaliable.

@AtesComp you can always suggest a PR on top of dereckdai-master-squashed and I will be happy to merge your suggestions.

As said, I will close this PR, it doesn't even compile so just confuse people looking for source implementation