-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle WebMeUp bots (BLEXBot) #158
Conversation
Btw, sorry for spamming PRs. I'm going over some IP addresses that are littering user tracking in my project, so I'm submitting for each of the top crawler bots that aren't already covered by This should be the last one for now. Thanks! |
No, no, your PRs are perfect. I do prefer to have separate commits for bots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #158 +/- ##
==========================================
+ Coverage 98.75% 98.77% +0.02%
==========================================
Files 25 26 +1
Lines 240 245 +5
==========================================
+ Hits 237 242 +5
Misses 3 3 ☔ View full report in Codecov by Sentry. |
I am a bit tied up at the moment, but will make a release this weekend latest. |
No worries. Thanks for taking a look so quickly! |
BLEXBot is a crawler that is responsible for a good chunk of bot requests on a website I manage (>200k requests over multiple IPs), so handling it with legitbot seems like a good idea.
The bot specs are available here: http://webmeup-crawler.com/
Let me know if any changes are needed.