fix: Add return statements in setScanPeriod and setBetweenScanPeriod to prevent IllegalStateException (#146) #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to prevent IllegalStateException This commit adds missing return statements after result.success and result.error calls in the setScanPeriod and setBetweenScanPeriod methods. This prevents the method from continuing execution and inadvertently calling result.notImplemented(), which was causing IllegalStateException due to multiple responses being sent for a single method call. Closes alann-maulana#146
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for creating this useful library!
Closes #146
Fix:
Added
return;statements** afterresult.success(true)andresult.error(...)in bothsetScanPeriodandsetBetweenScanPeriodmethods.Reason
The
setScanPeriodandsetBetweenScanPeriodmethods in theFlutterBeaconPluginwere missingreturnstatements after invokingresult.successorresult.error.This omission caused the methods to continue execution, inadvertently calling
result.notImplemented(),which led to an
IllegalStateExceptiondue to multiple responses being sent for a single method call.