-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
general_edits <- main #13
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing and adding to
new_writing <- main
… research proposal related to Privacy Law and Tech
…g which involves the removing of proper nouns.
…ontent - rectified.
…ll. Shifted some css styling rules to a media query which causes action sooner than what was set prior. This was done to solve a scaling problem that existed around a width of 300-350px related to the ul and table tags.
…th respect to the writings wrapper, (related to low resolutions). I forget why it's in place. There are some words in the references section of dataflow which aren't responsive friendly. Added overflow:auto to the section. Need to wrap some formulas of this page into their own non-justified tags.
…d to think of a way to have the text-align attribute have an affect here; revolves around the display property.
main <- new_writing
…on within comments.
…lementing piecemeal loading of images triggered by positional scrolling. The images being loaded will act as a buffer beyond th images that are loaded in but hidden via the opacity attribute.
…es of images are loaded in on page load is back. Unsure if this is because I'm currently developing on a different device. I'll have to revert back to the prior commit and test this device on it to see what's up.
…uncertain in the moment as to why.
image_gallery <- image_gallery_balanced_load
…ine the maximum amount of columns on a page; this will prevent extraneous calculations within the mobile environment.
… to a .js file which simply sets the manifest global variable to the json structure required. There is also an update to the manifest proper as it was previously setting empty arrays to the images that were recently ommitted.
…nism to the scrolling event handler.
…f the grid for the resize event handler.
main <- image_gallery
…g away the .then chaning of asynchronous function calling. I've also changed the timing of mutually recursive calls between the grid agents. I suspect the issue is stemming from the fact that I'm using height data taken straight from the VSCO json file
…ew variable to represent the height ratio of a given image with respect to some base width of which all images in a column will use. This is now used as the true measurement of an images' height. There still seems to be some lingering error such that images placed out of view aren't placed in the correct position.
…d meta information to the page in addition to bot crawl prevention.
…s of word-wrapping.
main <- image_gallery
alanmmckay
commented
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can probably remove manifest_bak.json. Also should do some image organization/conversions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bringing general_edits up to speed.