Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Streamlining #138

Merged
merged 45 commits into from
Oct 16, 2022
Merged

[WIP] Streamlining #138

merged 45 commits into from
Oct 16, 2022

Conversation

AoifeHughes
Copy link
Contributor

@AoifeHughes AoifeHughes commented Sep 30, 2022

This is an ambitious, and possibly stupid suggestion.
Thus, I'd suggest each changed file be thoroughly reviewed.

(Which I will do! Would be rude to ask anyone else to check I haven't broken everything.)

m1

  • 1.1-WhatIsDataScience
  • 1.2-DataScienceProjectLifecycle
  • 1.3-EDIForDataScience
  • 1.4-CollaborationAndReproducibility
  • hands-on
  • overview

m2

  • 2-01-01-WhereToFindData
  • 2-01-02-LegalityAndEthics
  • 2-01-03-PandasIntro
  • 2-01-04-DataSourcesAndFormats
  • 2-01-05-ControllingAccess
  • 2-01-GettingLoading
  • 2-02-01-DataConsistency
  • 2-02-02-ModifyingColumnsAndIndices
  • 2-02-03-FeatureEngineering
  • 2-02-04-01-TimeAndDateData
  • 2-02-04-02-TextData
  • 2-02-04-03-CategoricalData
  • 2-02-04-04-ImageData
  • 2-02-04-DataManipulation
  • 2-02-05-PrivacyAndAnonymisation
  • 2-02-06-LinkingDatasets
  • 2-02-07-MissingData
  • 2-02-ExploringWrangling
  • 2-hands-on-complete
  • 2-hands-on
  • 2-overview

m3

  • 3.1-FiguresGoneWrong
  • 3.2-RulesOfTheGame
  • 3.3-Atlas0fVisualisations
  • 3.4-StoryTelling
  • 3.5-DataVisForExploration
  • hands-on
  • overview

m4

  • 4.1_What_and_Why
  • 4.2_Fitting_Models
  • 4.3_Building_simple_model
  • 4.4_Evaluating_a_model
  • hands-on
  • overview

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@AoifeHughes AoifeHughes self-assigned this Sep 30, 2022
@AoifeHughes
Copy link
Contributor Author

Still think 1.1 has too much, but not sure! Need to think about how this is taught and how much material is needed.

@AoifeHughes
Copy link
Contributor Author

@callummole I just realised I've been merging back-to-back markdown cells - I'm guessing this will make it super annoying with respect to #126 for making slides?

I'll stop now, but if we do come up with suggestions or guidelines for teaching / prepping slides do let me know, and I'll adjust accordingly (only did this to 1.1. so far, and a few times in other places)

@AoifeHughes
Copy link
Contributor Author

As per meeting this morning with @callummole - he suggested we use a glossary to store a lot of the removed information caused by streamlinning the notebooks!

@AoifeHughes
Copy link
Contributor Author

quick thought c503cfa and some others have changed names. Can we make a note here to double-check there's no hard references in the book which reference to no dead files?

  • Check all links are healthy post-file-rename

@AoifeHughes
Copy link
Contributor Author

I noticed that some grammar things I'd previous fixed had become undone - partly fixed by 044550f

@AoifeHughes
Copy link
Contributor Author

Latest commit: 7c37bc3 still has myst issues, which are linked to exporting / creating slides. Thus, don't impact the course itself or the build. Still, warnings == errors, so this will need fixed soonish.

Will merge this branch once all files are reviewed and verified

@AoifeHughes AoifeHughes marked this pull request as ready for review October 16, 2022 16:33
@AoifeHughes AoifeHughes merged commit 2642bfd into develop Oct 16, 2022
@AoifeHughes AoifeHughes deleted the streamlining branch February 10, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant