Fix: no-unused-vars crash with spread operator (fixes #48)

aladdin-add · Jul 9, 2019 · df7892e · df7892e
1 parent f6daa04
commit df7892e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/rules/no-unused-vars.js b/lib/rules/no-unused-vars.js
@@ -83,7 +83,9 @@ module.exports = ruleComposer.mapReports(
                     return fixer.remove(parent);
                 case "RestElement":
                 case "Property":
-                    if (!grand) {
+
+                    // https://github.com/aladdin-add/eslint-plugin-autofix/issues/48
+                    if (!(grand && grand.type === "ObjectPattern")) {
                         return null;
                     }
 

diff --git a/tests/lib/rules/no-unused-vars.js b/tests/lib/rules/no-unused-vars.js
@@ -186,6 +186,12 @@ ruleTester.run("no-unused-vars", rule, {
             parserOptions: { ecmaVersion: 2018 },
             errors: [{ type: "Identifier" }]
         },
+        {
+            code: "function foo(...args){}",
+            output: null,
+            parserOptions: { ecmaVersion: 2018 },
+            errors: [{ type: "Identifier" }, { type: "Identifier" }]
+        },
         {
             code: "let {a} = b",
             output: "let {} = b",