-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove defaultProps from MeasureElement component #1818
base: master
Are you sure you want to change the base?
Conversation
Please review this, the error is really annoying and it will destroy the library in future |
@greenfrvr, Are you still involved with this repo? |
Hey! I think we'll need to remove default props for all the components. MeasureElement component is not the only one that uses default props. |
MeasureElement is the only function component I could find using defaultProps. The others are class components. |
@greenfrvr please merge this one, as |
I've posted a workaround to fix this one and #1782 until this PR is approved |
@greenfrvr, can you merge this and release a new version? |
bump, this should be an easy fix boys |
Looks like UI Kitten is dead. |
Too bad... it's one of the best UI libraries out there i think. |
+1 @greenfrvr |
@KostyaDanovsky @elupanov @malashkevich @lugovsky @SashaSkywalker @greenfrvr @sashaqred @Tibing @32penkin @mmfKupl Can anyone merge this or confirm UI Kitten is officially dead? |
+1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah just merge this in big dawg.
contributors are still on Christmas vacation, it seems |
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Resolves #1813