Fix issue #289 (unable to scroll to the bottom of the body's Widget when used with a Scaffold) #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wraps the panel's widget in a LayoutBuilder so that body can use the parent's max constraints for height and width. This allows the panel to play nicely with an AppBar if present, regardless of Scaffold.extendBodyBehindAppBar's value.
|
Great fix, cloud you pub your version directly, as it takes so long time from #44 (2019), this repo seems dead.. |
Added a tag to my repo so you could also just reference this fix in your |
|
@qixotic Hey, I know it's been a long time since you've created this PR, but shouldn't it also take into account the What I did (in this part): child: Container(
height: constraints.maxHeight - widget.minHeight,
width: constraints.maxWidth,
child: widget.body,
),Does this make sense? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #289 by modifying the builder to respect the parent's width/height constraints.
Also tweaks a few files so that one can build the example on iOS.
Looks like this issue has affected many versions, with a few PRs attempting to fix it or otherwise related: #44 #64 #92 #129. 64&92 take the same core approach of passing in constraints via a LayoutBuilder.