When closing the panel from (eg.) a tap on the backdrop, reset and turn off integrated panel scrolling #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willbryant
force-pushed
the
fix_backdrop_tap_with_builder
branch
from
3ba4c0a to
ad0cb55
Compare
This was referenced Apr 28, 2021
…rn off integrated panel scrolling Otherwise it's impossible to drag the panel up again by the header, because although we receive the drag events on the listener, _scrollingEnabled is set to true, so the slide handler ignores the event.
willbryant
force-pushed
the
fix_backdrop_tap_with_builder
branch
from
ad0cb55 to
afbc9a1
Compare
|
Rebased to master and fixed merge conflict with the |
|
@willbryant How did you achieve closing the panel with a tap in the backdrop? Should I use |
|
I don't have any references to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it's impossible to drag the panel up again by the header, because although we receive the drag events on the listener,
_scrollingEnabledis set to true, so the slide handler ignores the event.