Corrected name assigned to a singleton instance. #511
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As long as this doesn't break existing Akka.Hosting applications by changing the route of the singleton actor when it's being messaged via |
|
Because the problem you can run into is that during an incremental upgrade to an existing Akka.Cluster application, this can temporarily break messaging. |
|
Superseded via #520 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR resolves #509. Assuming that akka.cluster.singleton.singleton-name = singleton and the singleton is named my_singleton, an instance of a cluster singleton actor should have path //user/my_singleton/singleton, but extension methods WithSingleton and WithSingletonProxy assigned it to //user/my_singleton/my_singleton. This PR fixes this error.