Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename ES testkit utility method #120

Open
wants to merge 1 commit into
base: java-spi
Choose a base branch
from
Open

chore: rename ES testkit utility method #120

wants to merge 1 commit into from
+2 −2

Conversation

aludwiko
Copy link
Contributor

@aludwiko aludwiko commented Jan 1, 2025

No description provided.

efgpinto
efgpinto approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@efgpinto efgpinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This didEmitEvents() was present in the last released version, right? If so, this is a breaking change I guess. Not a big deal since this is only on the testkit though. So probably good to go as is?

@aludwiko
Copy link
Contributor Author

aludwiko commented Jan 6, 2025

Yes, it will be a breaking change, but with low importance. Actually, I could start with the deprecation of the old method first, but I was surprised that we don't use that method ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efgpinto efgpinto efgpinto approved these changes

@pvlugter pvlugter pvlugter approved these changes

Assignees
No one assigned
Labels
java-sdk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aludwiko @pvlugter @efgpinto