chore: aligning view store sample #118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aludwiko
commented
Dec 27, 2024
aludwiko
commented
- package structure
- Endpoints instead of direct component calls
- removing remaining direct component calls docs
aludwiko
commented
Dec 27, 2024
| @@ -1,19 +1,19 @@ | |||
| package store.view.joined; | |||
| package store.order.view.joined; | |||
There was a problem hiding this comment.
I've decided to keep a separate "view" package, because that's what we want to highlight in this sample.
pvlugter
reviewed
Jan 6, 2025
Comment on lines
46
to
65
| @Get("/joined-by-customer/{customerId}") | ||
| public CompletionStage<JoinedCustomerOrdersView.CustomerOrders> joinedByCustomer(String customerId) { | ||
| return componentClient.forView() | ||
| .method(JoinedCustomerOrdersView::get) | ||
| .invokeAsync(customerId); | ||
| } | ||
|
|
||
| @Get("/nested-by-customer/{customerId}") | ||
| public CompletionStage<CustomerOrders> nestedByCustomer(String customerId) { | ||
| return componentClient.forView() | ||
| .method(NestedCustomerOrdersView::get) | ||
| .invokeAsync(customerId); | ||
| } | ||
|
|
||
| @Get("/structured-by-customer/{customerId}") | ||
| public CompletionStage<store.order.view.structured.CustomerOrders> structuredByCustomer(String customerId) { | ||
| return componentClient.forView() | ||
| .method(StructuredCustomerOrdersView::get) | ||
| .invokeAsync(customerId); | ||
| } |
There was a problem hiding this comment.
This is the only part that doesn't read so well to me, with importing the different CustomerOrders in different ways — directly, nested class, full package. Could be be better to prefix each of those classes instead:
public CompletionStage<JoinedCustomerOrders> joinedByCustomer(String customerId)
public CompletionStage<NestedCustomerOrders> nestedByCustomer(String customerId)
public CompletionStage<StructuredCustomerOrders> structuredByCustomer(String customerId)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.