feat(deployment): ensure user can re-send manifest #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baktun14
approved these changes
Sep 20, 2024
after creating a lease and initial send failure
ygrishajev
force-pushed
the
feature/deployment
branch
from
0db3775 to
640cdaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits create lease main function into 2: creating a lease and sending a manifest. The second happens if the first is successful and a state is updated accordingly. If it's not user can retry manually.
This doesn't still solve an issue if user tries to navigate to such deployment from the deployment list. In this case deployment isn't functional and it's not obvious why.