add search functionality #25
Conversation
|
Thanks @akabiru for the label. |
There was a problem hiding this comment.
Hi @andela-aadepoju, I appreciate the good work you've put in. Having tested this current search implementation; I think it'd be good to implement with fuzzy search in mind. Such that when I run sth like hscode -s not, the output should include all status codes with descriptions matching 'not' such as Not Implemented, Not Modified e.t.c. Would love to hear your thoughts on this.
lib/hscode/input_parser.rb
Outdated
| hscode -c 200 | ||
| hscode -c 200 -v | ||
| hscode -l | ||
| hscode -s ok |
There was a problem hiding this comment.
I'd recommend that we have search examples come after "list descriptions" (hscode -l 2xx) for consistency.
spec/hscode/input_parser_spec.rb
Outdated
| @@ -68,6 +68,22 @@ | |||
| end | |||
| end | |||
|
|
|||
| context 'search for code with title' do | |||
| it 'sees -s as a valid request' do | |||
There was a problem hiding this comment.
prefer detects -s to sees -s; command to request.
There was a problem hiding this comment.
Hey @andela-aadepoju, just to let you know I reviewed your PR and run some tests. We still need a few tweaks to get the fuzzy search working. I'll see if I can contribute to your PR to get a clearer view of what we need to do to get this working. Bear with us bro. 🙂
|
Hey @akabiru No problem, buzz me up if you need anything. |
What does this PR do?