Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update Node.js versions for CI builds #2357

Conversation

egfx-notifications
Copy link
Contributor

@egfx-notifications egfx-notifications commented Dec 20, 2023

What issue does this pull request resolve?
Fixes #2330

re2 no longer works for NodeJS v14 and thus the CI fails for all new PRs

NodeJS v16 has also dropped out of support

Please note that NodeJS v21 will only work after #2356 has been merged (and the CI in #2356 will fail for NodeJS v14 without this PR). So either merge both regardless of CI or we have to make a commit without v21 first, then merge #2356, then add another PR for v21.

re2 no longer works for NodeJS v14 and thus the CI fails for all new PRs

NodeJS v16 has also dropped out of support

Fixes ajv-validator#2330
@jasoniangreen
Copy link
Collaborator

jasoniangreen commented Feb 14, 2024

Thanks for this. I say let's remove 21.x first, merge and then apply your other fix adding it back.

@jasoniangreen
Copy link
Collaborator

This has been done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

build(deps): update Node.js versions for CI builds
2 participants