Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update broken dependencies #4

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update broken dependencies #4

wants to merge 3 commits into from

Conversation

matt852
Copy link
Contributor

@matt852 matt852 commented Oct 9, 2024

Fixes broken dependency from #1

@ajnart
Copy link
Owner

ajnart commented Oct 9, 2024

Can you change the PR so that it deletes the component file ? This is a shadcn component that we don't use as of now. I believe you can also delete the dependency

@matt852
Copy link
Contributor Author

matt852 commented Oct 9, 2024

Can you change the PR so that it deletes the component file ? This is a shadcn component that we don't use as of now. I believe you can also delete the dependency

Updated. Did you want me to also remove the react-day-picker?

@A-Specker
Copy link

import MadeWithKodu from "~/components/MadeWithKodu";

The 'MadeWithKodu' is also an unused component which fails my build

@ajnart
Copy link
Owner

ajnart commented Oct 9, 2024

import MadeWithKodu from "~/components/MadeWithKodu";

The 'MadeWithKodu' is also an unused component which fails my build

Oops, I'll fix the build don't worry. I need to format the codebase and edit the biome config to make it more permissive in general.

@ajnart
Copy link
Owner

ajnart commented Oct 9, 2024

Can you change the PR so that it deletes the component file ? This is a shadcn component that we don't use as of now. I believe you can also delete the dependency

Updated. Did you want me to also remove the react-day-picker?

For now yes, I think i'll update the linter to ignore these components in general so that it doesn't produce errors. We'll make a date picker once I implement the ability to set a renewal date for a subscription, but that will be done later

@matt852
Copy link
Contributor Author

matt852 commented Oct 9, 2024

Can you change the PR so that it deletes the component file ? This is a shadcn component that we don't use as of now. I believe you can also delete the dependency

Updated. Did you want me to also remove the react-day-picker?

For now yes, I think i'll update the linter to ignore these components in general so that it doesn't produce errors. We'll make a date picker once I implement the ability to set a renewal date for a subscription, but that will be done later

Done

@ajnart
Copy link
Owner

ajnart commented Oct 10, 2024

You should have deleted the component and not the components.json file aha. But that's okay. I have taken your feedback and pushed the changes to the main branch. The repo should build properly now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants