Hotfix support for files

ajmariduena · Mar 3, 2019 · cad0a10 · cad0a10
1 parent 411aace
commit cad0a10
Show file tree

Hide file tree

Showing 5 changed files with 36 additions and 18 deletions.
diff --git a/config/settings.php b/config/settings.php
@@ -1,7 +1,6 @@
 <?php
 
 return [
-
     /*
     |--------------------------------------------------------------------------
     | Settings Path
@@ -29,6 +28,17 @@
 
     'navigation' => 'Settings',
 
+    /*
+    |--------------------------------------------------------------------------
+    | Settings Disk
+    |--------------------------------------------------------------------------
+    |
+    | Specified disk for storing settings files.
+    |
+    */
+
+    'disk' => 'public',
+
     /*
     |--------------------------------------------------------------------------
     | Settings
@@ -45,13 +55,10 @@
     */
 
     'panels' => [
-
         [
-
             'name' => 'Settings',
 
             'settings' => [
-
                 [
                     'key' => 'facebook_url',
                     'name' => 'Facebook',
@@ -73,17 +80,13 @@
                         'url' => '/documentation#twitter_url',
                     ],
                 ],
-
             ],
-
         ],
 
         [
-
             'name' => 'Features',
 
             'settings' => [
-
                 [
                     'key' => 'new_feature',
                     'name' => 'New Feature',
@@ -94,11 +97,7 @@
                         'url' => '/documentation#new_feature',
                     ],
                 ],
-
             ],
-
         ],
-
     ],
-
 ];
diff --git a/dist/js/tool.js b/dist/js/tool.js
diff --git a/resources/js/components/SettingsTool.vue b/resources/js/components/SettingsTool.vue
@@ -28,6 +28,7 @@
                     <file-setting
                         v-if="setting.type == 'file'"
                         :name="setting.name"
+                        :accept="setting.accept"
                         :description="setting.description || ''"
                         :link="setting.link || {}"
                         :setting="{ key: setting.key, value: settings[setting.key] }"

diff --git a/resources/js/components/partials/File.vue b/resources/js/components/partials/File.vue
@@ -15,10 +15,11 @@
             <input 
                 type="file"
                 @input="input"
+                :accept="accept"
                 class="form-file-input"
-                id="image"
+                :id="setting.key"
             />
-            <label for="image" class="form-file-btn btn btn-default btn-primary">
+            <label :for="setting.key" class="form-file-btn btn btn-default btn-primary">
                 {{ __('Choose File') }}
             </label>
 
@@ -38,6 +39,7 @@ export default {
         name: String,
         setting: Object,
         description: String,
+        accept: String,
         link: Object
     },
 

diff --git a/src/Http/Controllers/SettingsToolController.php b/src/Http/Controllers/SettingsToolController.php
@@ -52,13 +52,29 @@ public function write(Request $request)
 
                 $settings->put($setting, Storage::url($filePath));
             } else {
-                if ($value === 'null') {
-                    $value = null;
-                }
+                $value = $this->castValue($value);
                 $settings->put($setting, $value);
             }
         }
 
         return response($settings->all(), 202);
     }
+
+    private function castValue($value)
+    {
+        switch ($value) {
+            case 'null':
+                return null;
+                break;
+            case 'true':
+                return true;
+                break;
+            case 'false':
+                return false;
+                break;
+            default:
+                return $value;
+                break;
+        }
+    }
 }