Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Book.java #96

Closed
wants to merge 1 commit into from
Closed

Update Book.java #96

wants to merge 1 commit into from

Conversation

Tanisha0708
Copy link
Contributor

Added private String keyword; to hold the keyword information. Added getKeyword and setKeyword methods.
Fixed the toString method to properly display keyword. by using the keyword it will be easy to search book

Added private String keyword; to hold the keyword information.
Added getKeyword and setKeyword methods.
Fixed the toString method to properly display keyword.
by using the keyword it will be easy to search book
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you @Tanisha0708 for your contribution! Your pull request has been submitted successfully, and a maintainer will review it soon. We’re excited to have you on board! Remember to star the repo 🌟 to help us grow, and follow @ajaynegi45 to stay in the loop and increase the visibility of your contributions!

@Tanisha0708
Copy link
Contributor Author

@ajaynegi45 once go through this change

Copy link
Owner

@ajaynegi45 ajaynegi45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Tanisha0708,

Thank you for your prompt work on this issue. I appreciate your dedication to the project.

I have reviewed your work, and I'm pleased to inform you that I have merged your pull request. Your changes looks fantastic, and it aligns perfectly with the project's design and usability goals. Great job!

If you have any more contributions or if there's anything else you'd like to work on in the future, please don't hesitate to let us know. Your efforts are valuable to the project's success.

Once again, thank you for your contribution! ❤️

Copy link
Contributor

@Devamani11D Devamani11D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!!

@Devamani11D
Copy link
Contributor

@ajaynegi45 Why there is no merge option here?

@Guhapriya01
Copy link
Collaborator

@Tanisha0708, great job adding the keyword attribute to the Book class! I wanted to point out that we’ll also need to update other classes (like BookDto and BookService) to accommodate this change.

@Guhapriya01
Copy link
Collaborator

Guhapriya01 commented Nov 2, 2024

@Tanisha0708, great job adding the keyword attribute to the Book class! I wanted to point out that we’ll also need to update other classes (like BookDto and BookService) to accommodate this change.

@ajaynegi45, since you approved this PR, could you please take a look at it?

@ajaynegi45
Copy link
Owner

@Tanisha0708, great job adding the keyword attribute to the Book class! I wanted to point out that we’ll also need to update other classes (like BookDto and BookService) to accommodate this change.

@Tanisha0708, accommodate this change in pr

@ajaynegi45 ajaynegi45 closed this Nov 2, 2024
@Tanisha0708
Copy link
Contributor Author

@ajaynegi45 once go through the pull request . i did some changes in BookDto and BookService

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants