Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: additional_disk space and service_integrations fields import (#1820) #1846

Merged
merged 14 commits into from
Oct 8, 2024
Merged

fix: additional_disk space and service_integrations fields import (#1820) #1846

merged 14 commits into from
Oct 8, 2024

Conversation

rriski
Copy link
Contributor

@rriski rriski commented Sep 17, 2024 •
edited
Loading

About this change—what it does

Fix #1820. Previously, we didn't handle additional_disk_space and service_integrations properly during terraform import. This changeset also fixes importing the tech_emails field.

@rriski rriski changed the title Rriski fix service tf import fix: additional_disk space and service_integrations fields import (#1820) Sep 17, 2024
@rriski rriski force-pushed the rriski-fix-service-tf-import branch 5 times, most recently from 4b64d51 to 39b861d Compare September 19, 2024 14:31
@rriski rriski force-pushed the rriski-fix-service-tf-import branch 3 times, most recently from 04c2d85 to 5863c26 Compare October 7, 2024 16:12
@rriski
Copy link
Contributor Author

rriski commented Oct 7, 2024

tests

@rriski rriski marked this pull request as ready for review October 7, 2024 18:19
@rriski rriski requested a review from a team as a code owner October 7, 2024 18:19
rriski added 14 commits October 8, 2024 13:57
@rriski
fix: import disk space fields (#1820)
cfc3ea1
@rriski
fix: import technical emails field (#1820)
af8729f
@rriski
chore: simplify tech emails helper function
7b8dd00
@rriski
fix: import service_integrations field (#1820)
05f4f95
@rriski
fix: typo in static ip documentation
9697c3c
@rriski
fix: set either disk_space or additional_disk_space (#1820)
6d8cb72
@rriski
chore: remove useless helper from pg_database_test.go
43b3ff8
@rriski
fix: fix disk space handling in service create / update
fe88228 
Previously additional_disk_space field would be ignored if disk_space was not set.
@rriski
fix: mark project_vpc_id field as computed
4c72623
@rriski
fix: mark service_integrations field as computed
870b4b1
@rriski
feat: use generated client in schemautil service.go
d983523
@rriski
feat: deprecate disk_space_used
f218184 
We don't seem to have it in the API and its set to the same
value as `disk_space`.
@rriski
feat: improve disk space custom diff error message
e810de8
@rriski
feat: add pg import test (#1820)
8486629
@rriski rriski force-pushed the rriski-fix-service-tf-import branch from 5863c26 to 8486629 Compare October 8, 2024 10:59
@byashimov byashimov enabled auto-merge (squash) October 8, 2024 12:33
@byashimov byashimov merged commit f7a7a5c into main Oct 8, 2024
11 checks passed
@byashimov byashimov deleted the rriski-fix-service-tf-import branch October 8, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byashimov byashimov byashimov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Attributes from Import of avien_pg Resource
2 participants
@rriski @byashimov