feat: add support for topic description and ownership #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roope-kar
force-pushed
the
rkar-add-support-for-topic-description-and-ownership
branch
4 times, most recently
from
64b7f18 to
90b353c
Compare
byashimov
reviewed
Sep 13, 2024
byashimov
reviewed
Sep 13, 2024
byashimov
previously requested changes
Sep 13, 2024
roope-kar
force-pushed
the
rkar-add-support-for-topic-description-and-ownership
branch
2 times, most recently
from
fbf72ae to
62c6fef
Compare
|
@byashimov Thank you for the review. I moved the changelog entry and moved the related tests into own test case. |
roope-kar
force-pushed
the
rkar-add-support-for-topic-description-and-ownership
branch
3 times, most recently
from
b0e8124 to
975bfbb
Compare
roope-kar
force-pushed
the
rkar-add-support-for-topic-description-and-ownership
branch
from
975bfbb to
817917f
Compare
byashimov
reviewed
Sep 16, 2024
roope-kar
force-pushed
the
rkar-add-support-for-topic-description-and-ownership
branch
2 times, most recently
from
00f0ebf to
785db92
Compare
|
Rebased |
roope-kar
force-pushed
the
rkar-add-support-for-topic-description-and-ownership
branch
from
785db92 to
0d260b0
Compare
byashimov
approved these changes
Sep 16, 2024
Add capability to set description and owner group per topic.
byashimov
force-pushed
the
rkar-add-support-for-topic-description-and-ownership
branch
from
0d260b0 to
515cbc1
Compare
byashimov
deleted the
rkar-add-support-for-topic-description-and-ownership
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change—what it does
Add capability to set description and owner group per topic.
Why this way
topic description and owner user group are now supported per topic in aiven API's. Both fields are optional. Especially the owner group field will provide basic governing functionality by being able to mark owner to a topic.
Worth mentioning is that due to how the Aiven topic update endpoint works (fields are reset by sending the field as null to the endpoint) it is not possible to remove the field from config to unset it. In order to unset one of these fields,
terraform destroyandterraform applymust be done in order to completely unset these fields.