Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(userconfig/converters): missing negation in ip_filter safeguard #1644

Merged
merged 1 commit into from
Mar 11, 2024
Merged

fix(userconfig/converters): missing negation in ip_filter safeguard #1644

merged 1 commit into from
Mar 11, 2024

Conversation

Serpentiel
Copy link
Contributor

About this change—what it does

there's a missing negation in the ip_filter safeguard, this PR brings it

Why this way

it was missing 🤷

@Serpentiel Serpentiel added bug Something isn't working no changelog No changelog entries are required for this PR labels Mar 11, 2024
@Serpentiel Serpentiel self-assigned this Mar 11, 2024
@Serpentiel Serpentiel requested a review from a team March 11, 2024 11:10
@Serpentiel Serpentiel enabled auto-merge (squash) March 11, 2024 11:10
SmuliS
SmuliS approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@SmuliS SmuliS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and thanks for the quick fix. Glad we did a small manual test before releasing this.

@Serpentiel Serpentiel merged commit 74de9d9 into main Mar 11, 2024
29 checks passed
@Serpentiel Serpentiel deleted the aleks-fix-userconfig-converters-missing-negation-in-ip-filter-safeguard branch March 11, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SmuliS SmuliS SmuliS approved these changes

Assignees

@Serpentiel Serpentiel

Labels
bug Something isn't working no changelog No changelog entries are required for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Serpentiel @SmuliS