fix(kafka_schema): protobuf normalization #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byashimov
reviewed
Feb 27, 2024
Serpentiel
force-pushed
the
aleks-fix-kafka-schema-protobuf-normalization
branch
from
0dc0eb5 to
85fd819
Compare
byashimov
reviewed
Feb 27, 2024
Serpentiel
force-pushed
the
aleks-fix-kafka-schema-protobuf-normalization
branch
from
85fd819 to
ee710a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change—what it does
fixes
kafka_schemaProtobuf normalizationWhy this way
the test was failing, the normalization mechanism wasn't perfect