Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unnecessary comment #1612

Merged
merged 2 commits into from
Feb 23, 2024
Merged

chore: remove unnecessary comment #1612

merged 2 commits into from
Feb 23, 2024

Conversation

jeff-held-aiven
Copy link
Contributor

No description provided.

@jeff-held-aiven jeff-held-aiven requested a review from a team February 22, 2024 13:51
Serpentiel
Serpentiel reviewed Feb 22, 2024
View reviewed changes
Copy link
Contributor

@Serpentiel Serpentiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but could you also remove the one in flink_application_deployment.go?

@Serpentiel Serpentiel self-assigned this Feb 22, 2024
@Serpentiel Serpentiel added enhancement New feature or request no changelog No changelog entries are required for this PR labels Feb 22, 2024
@jeff-held-aiven jeff-held-aiven force-pushed the jeff-held-aiven-remove-comment branch from fd2d681 to e4005ed Compare February 23, 2024 08:10
Serpentiel
Serpentiel previously approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@Serpentiel Serpentiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Serpentiel Serpentiel enabled auto-merge (squash) February 23, 2024 10:34
@Serpentiel Serpentiel merged commit 2b6d4ad into main Feb 23, 2024
10 checks passed
@Serpentiel Serpentiel deleted the jeff-held-aiven-remove-comment branch February 23, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Serpentiel Serpentiel Serpentiel approved these changes

Assignees

@Serpentiel Serpentiel

Labels
enhancement New feature or request no changelog No changelog entries are required for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeff-held-aiven @Serpentiel