Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix examples #1594

Merged
merged 1 commit into from
Feb 15, 2024
Merged

docs: fix examples #1594

merged 1 commit into from
Feb 15, 2024

Conversation

staceysalamon-aiven
Copy link
Contributor

About this change—what it does

  • Remove deprecated fields.
  • Add required_version field.
  • Standardize some placeholders.
  • Change comments to use # consistently.
  • Add introduction to get started README.
  • Some other minor adjustments for grammar, consistency.

@staceysalamon-aiven staceysalamon-aiven added documentation Improvements or additions to documentation no changelog No changelog entries are required for this PR labels Feb 14, 2024
@staceysalamon-aiven staceysalamon-aiven self-assigned this Feb 14, 2024
@staceysalamon-aiven staceysalamon-aiven force-pushed the staceys-update-examples-si-5038 branch 2 times, most recently from 1351450 to 87f3303 Compare February 14, 2024 16:31
@staceysalamon-aiven staceysalamon-aiven marked this pull request as ready for review February 14, 2024 16:36
@staceysalamon-aiven staceysalamon-aiven requested a review from a team February 14, 2024 16:36
@Serpentiel Serpentiel force-pushed the staceys-update-examples-si-5038 branch from 87f3303 to 76cf6f8 Compare February 15, 2024 08:53
Copy link
Contributor

@Serpentiel Serpentiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Serpentiel Serpentiel enabled auto-merge (squash) February 15, 2024 08:55
@Serpentiel Serpentiel merged commit 1f88422 into main Feb 15, 2024
10 checks passed
@Serpentiel Serpentiel deleted the staceys-update-examples-si-5038 branch February 15, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation no changelog No changelog entries are required for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants