Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use v2/helpers/retry instead of helper/resource #1592

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

jeff-held-aiven
Copy link
Contributor

About this change—what it does

github.com/hashicorp/terraform-plugin-testing/helper/resource is deprecated, and it was recommend that github.com/hashicorp/terraform-plugin-sdk/v2/helper/retry be used instead.

Resolves: #xxxxx.

Why this way

To eliminate the use of deprecated APIs

@jeff-held-aiven jeff-held-aiven requested a review from a team February 13, 2024 15:20
github.com/hashicorp/terraform-plugin-testing/helper/resource is
deprecated, and it was recommend that
github.com/hashicorp/terraform-plugin-sdk/v2/helper/retry be used
instead.
@jeff-held-aiven jeff-held-aiven force-pushed the jeff-held-aiven-use-helper/retry branch from b9de078 to 3f5a20b Compare February 13, 2024 15:33
Copy link
Contributor

@Serpentiel Serpentiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Serpentiel Serpentiel self-assigned this Feb 13, 2024
@Serpentiel Serpentiel merged commit a57a9d1 into main Feb 13, 2024
11 checks passed
@Serpentiel Serpentiel deleted the jeff-held-aiven-use-helper/retry branch February 13, 2024 15:41
@Serpentiel Serpentiel added the enhancement New feature or request label Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants