Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add sweep check #1542

Merged
merged 1 commit into from
Jan 19, 2024
Merged

ci: add sweep check #1542

merged 1 commit into from
Jan 19, 2024

Conversation

ivan-savciuc
Copy link
Contributor

About this change—what it does

Add sweeper check CI job

@ivan-savciuc ivan-savciuc requested a review from a team January 18, 2024 18:55
@ivan-savciuc ivan-savciuc added the no changelog No changelog entries are required for this PR label Jan 18, 2024
.github/workflows/sweep-check.yaml Outdated Show resolved Hide resolved
@Serpentiel Serpentiel self-assigned this Jan 18, 2024
@Serpentiel Serpentiel added the enhancement New feature or request label Jan 18, 2024
@ivan-savciuc ivan-savciuc force-pushed the ivans-add-sweep-check-workflow branch from 1d7467a to e436e5c Compare January 19, 2024 07:23
@ivan-savciuc ivan-savciuc dismissed Serpentiel’s stale review January 19, 2024 07:23

moved to lint.yaml

@ivan-savciuc ivan-savciuc marked this pull request as draft January 19, 2024 07:26
@ivan-savciuc ivan-savciuc force-pushed the ivans-add-sweep-check-workflow branch from e436e5c to 4d12507 Compare January 19, 2024 07:38
@ivan-savciuc ivan-savciuc marked this pull request as ready for review January 19, 2024 07:39
Copy link
Contributor

@byashimov byashimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey. Could you please put the client part into a function, so it's not duplicated so many times. WDYT?

@ivan-savciuc ivan-savciuc force-pushed the ivans-add-sweep-check-workflow branch from 4d12507 to 0fddeb6 Compare January 19, 2024 09:38
Copy link
Contributor

@byashimov byashimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ivan-savciuc ivan-savciuc force-pushed the ivans-add-sweep-check-workflow branch from 0fddeb6 to 952b634 Compare January 19, 2024 12:14
@ivan-savciuc ivan-savciuc enabled auto-merge (squash) January 19, 2024 12:14
@ivan-savciuc ivan-savciuc merged commit 7dce9e5 into main Jan 19, 2024
10 checks passed
@ivan-savciuc ivan-savciuc deleted the ivans-add-sweep-check-workflow branch January 19, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request no changelog No changelog entries are required for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants