Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kafka_topic): configure insufficient brokers error retries timeout #1507

Merged

Conversation

byashimov
Copy link
Contributor

About this change—what it does

Uses default context timeout for kafka topic create operation when gets "insufficient broker" error.

@byashimov byashimov force-pushed the byashimov-configure-insufficient-broker-error-timeout branch from 970c1e4 to 9d5cf82 Compare January 4, 2024 09:06
@byashimov
Copy link
Contributor Author

tests

@byashimov byashimov force-pushed the byashimov-configure-insufficient-broker-error-timeout branch from 50014a1 to a935b20 Compare January 8, 2024 14:30
@byashimov byashimov marked this pull request as ready for review January 8, 2024 14:32
@byashimov byashimov requested a review from a team January 8, 2024 14:32
@byashimov
Copy link
Contributor Author

Merged main to keep v4.12.1-rc1 tag in main.

@byashimov
Copy link
Contributor Author

@Serpentiel @ivan-savciuc let's merge this TWO commits to the main to not loose the rc1 tag.

Copy link
Contributor

@ivan-savciuc ivan-savciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@byashimov byashimov merged commit 271b2c1 into main Jan 9, 2024
10 checks passed
@byashimov byashimov deleted the byashimov-configure-insufficient-broker-error-timeout branch January 9, 2024 08:15
@Serpentiel Serpentiel added the bug Something isn't working label Jan 9, 2024
@Serpentiel Serpentiel assigned byashimov and unassigned ivan-savciuc Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants