Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(service): add connection_info field to components #1457

Merged

Conversation

Serpentiel
Copy link
Contributor

About this change—what it does

adds connection_info field to components of all services

resolves #1444

Why this way

to provide with a convenient way to retrieve host:port string and ease the process of usage of those fields

@Serpentiel Serpentiel added the enhancement New feature or request label Nov 24, 2023
@Serpentiel Serpentiel requested a review from a team November 24, 2023 15:54
Copy link
Contributor

@ivan-savciuc ivan-savciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivan-savciuc ivan-savciuc merged commit 8e1bc6c into main Nov 24, 2023
18 checks passed
@ivan-savciuc ivan-savciuc deleted the aleks-feat-service-add-connection-info-field-to-components branch November 24, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide Kafka SASL connect uri on aiven_kafka
2 participants