Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(changelog): improve header #1434

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

Serpentiel
Copy link
Contributor

@Serpentiel Serpentiel commented Nov 8, 2023

About this change—what it does

added a comment to improve the header

Why this way

we forget to keep the header from time to time

@Serpentiel Serpentiel added documentation Improvements or additions to documentation no changelog No changelog entries are required for this PR labels Nov 8, 2023
@Serpentiel Serpentiel self-assigned this Nov 8, 2023
@Serpentiel Serpentiel requested a review from a team November 8, 2023 12:04
@Serpentiel Serpentiel removed their assignment Nov 8, 2023
@Serpentiel Serpentiel force-pushed the aleks-chore-changelog-drop-v5-entries branch 2 times, most recently from 39e021d to c307763 Compare November 8, 2023 13:54
CHANGELOG.md Outdated Show resolved Hide resolved
@Serpentiel Serpentiel requested a review from byashimov November 9, 2023 11:50
@Serpentiel Serpentiel force-pushed the aleks-chore-changelog-drop-v5-entries branch from c307763 to eb27d7c Compare November 9, 2023 11:50
byashimov

This comment was marked as outdated.

Copy link
Contributor

@byashimov byashimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts. Otherwise lgtm

@Serpentiel Serpentiel changed the title chore(changelog): drop v5 entries chore(changelog): improve header Nov 13, 2023
@Serpentiel Serpentiel requested a review from byashimov November 13, 2023 08:59
@Serpentiel Serpentiel self-assigned this Nov 13, 2023
@Serpentiel Serpentiel enabled auto-merge (squash) November 13, 2023 08:59
Copy link
Contributor

@byashimov byashimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Serpentiel Serpentiel merged commit 864954b into main Nov 13, 2023
10 checks passed
@Serpentiel Serpentiel deleted the aleks-chore-changelog-drop-v5-entries branch November 13, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation no changelog No changelog entries are required for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants