-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(changelog): improve header #1434
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serpentiel
added
documentation
Improvements or additions to documentation
no changelog
No changelog entries are required for this PR
labels
Nov 8, 2023
Serpentiel
force-pushed
the
aleks-chore-changelog-drop-v5-entries
branch
2 times, most recently
from
November 8, 2023 13:54
39e021d
to
c307763
Compare
byashimov
reviewed
Nov 8, 2023
Serpentiel
force-pushed
the
aleks-chore-changelog-drop-v5-entries
branch
from
November 9, 2023 11:50
c307763
to
eb27d7c
Compare
byashimov
requested changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve conflicts. Otherwise lgtm
Serpentiel
changed the title
chore(changelog): drop v5 entries
chore(changelog): improve header
Nov 13, 2023
byashimov
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
no changelog
No changelog entries are required for this PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change—what it does
added a comment to improve the header
Why this way
we forget to keep the header from time to time