docs: document other env vars for make test-acc #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigmaris
force-pushed
the
sigmaris-improve-docs-somewhat
branch
2 times, most recently
from
d39c58e to
5cf5a50
Compare
Serpentiel
previously requested changes
Nov 8, 2023
sigmaris
force-pushed
the
sigmaris-improve-docs-somewhat
branch
from
5cf5a50 to
86937f0
Compare
|
The semgrep action also seems broken, though unrelated to this change. |
I'm currently working on it :) |
sigmaris
force-pushed
the
sigmaris-improve-docs-somewhat
branch
from
86937f0 to
7ed094b
Compare
Fully running the acceptance tests uses more than just a project, there are tests which interact with accounts and orgs, so we should probably document how to get them to run here.
Serpentiel
force-pushed
the
sigmaris-improve-docs-somewhat
branch
from
7ed094b to
f323637
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change—what it does
Improves documentation of the environment variables that are used or influence the running of the acceptance tests.
Why this way
Fully running the acceptance tests uses more than just a project, there are tests which interact with accounts and orgs, and it took some questioning on Slack and searching the source code to figure out how to properly run these tests locally and against a dev environment, so we should probably document how to get them to run here to save future engineers time.