Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(flink): fix application version flakiness #1406

Merged

Conversation

Serpentiel
Copy link
Contributor

About this change—what it does

fixes Flink application version flakiness

Why this way

to make it work :)

@Serpentiel Serpentiel added bug Something isn't working no changelog No changelog entries are required for this PR labels Oct 23, 2023
@Serpentiel Serpentiel requested a review from a team October 23, 2023 09:29
@Serpentiel Serpentiel force-pushed the aleks-test-flink-fix-application-version-flakiness branch from 19827ad to 7b85084 Compare October 23, 2023 09:30
Copy link
Contributor

@ivan-savciuc ivan-savciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a small suggestion for catching the right error

@Serpentiel Serpentiel force-pushed the aleks-test-flink-fix-application-version-flakiness branch from 7b85084 to d9365c0 Compare October 23, 2023 16:47
@Serpentiel Serpentiel force-pushed the aleks-test-flink-fix-application-version-flakiness branch from d9365c0 to 5cbb344 Compare October 23, 2023 17:13
Copy link
Contributor

@ivan-savciuc ivan-savciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivan-savciuc ivan-savciuc enabled auto-merge (squash) October 24, 2023 06:21
@ivan-savciuc ivan-savciuc merged commit eaa7300 into main Oct 24, 2023
10 checks passed
@ivan-savciuc ivan-savciuc deleted the aleks-test-flink-fix-application-version-flakiness branch October 24, 2023 06:22
Serpentiel added a commit that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no changelog No changelog entries are required for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants